Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify EncryptedRPC Client #1877

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Simplify EncryptedRPC Client #1877

merged 4 commits into from
Apr 15, 2024

Conversation

tudor-malene
Copy link
Collaborator

@tudor-malene tudor-malene commented Apr 12, 2024

Why this change is needed

To remove unnecessary operations and clarify responsibilities ( reduce WTFs)

What changes were made as part of this PR

  • remove unnecessary IDAndLog and IDAndEncLog types
  • use the standard message forwarder for the encrypted log subscription
  • remove unnecessary marshalling and unmarshalling of the EVM errors and the extra custom logic in the encrypted rpc client.

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tudor-malene tudor-malene merged commit 4e6e239 into main Apr 15, 2024
2 checks passed
@tudor-malene tudor-malene deleted the tudor/more_cleanup branch April 15, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants